Fix timestamp incorrect unit (off by 1000)

scylladb / kafka-connect-scylladb

Kafka Connect Scylladb Sink

Apache License 2.0

46 stars 22 forks source link

Fix timestamp incorrect unit (off by 1000) #29

Closed avelanarius closed 3 years ago

avelanarius commented 3 years ago

Fix timestamps set on BoundStatement: timestamps on bound statements expect a microsecond precision, but a Kafka timestamp with a millisecond precision was set without conversion.

Fixes #28 - when a CDC table was set as a destination, a row with invalid timestamp (in year 1970 due to invalid units) would be attempted to be inserted and it would fail, as 1970 is earlier than any CDC generation.

Psykepro commented 3 years ago

I've tested with this change and now works this will fix my issue :) please merge it when possible: https://github.com/scylladb/kafka-connect-scylladb/issues/28