Fix VersionUtil::getVersion()

scylladb / kafka-connect-scylladb

Kafka Connect Scylladb Sink

Apache License 2.0

42 stars 22 forks source link

Fix VersionUtil::getVersion() #41

Closed avelanarius closed 3 years ago

avelanarius commented 3 years ago

Fix VersionUtil::getVersion(). The new way the version is loaded is inspired by Debezium connectors and Scylla CDC Source Connector.

The version is stored in version.properties resource file and Maven during the build-time fills this file with a version number. VersionUtil can then read it in runtime, by loading the properties file.

Fixes #39.

haaawk commented 3 years ago

LGTM in general but I think neither nor element is really needed and can be omitted.