Fix documentation about delivery guarantees

scylladb / kafka-connect-scylladb

Kafka Connect Scylladb Sink

Apache License 2.0

42 stars 22 forks source link

Fix documentation about delivery guarantees #46

Closed avelanarius closed 2 years ago

avelanarius commented 3 years ago

Remove incorrect information about exactly-once semantics of the connector. Even when running with offsets saved to Scylla, there could be a crash between a successful INSERT to Scylla and saving of the offset, causing a duplicate INSERT after a restart.

Add delivery guarantees section in README, describing that the connector is at-least-once, but how that it might not be relevant in most use cases.

Fixes #44.

raphaelauv commented 2 years ago

Is the repo no more active ? Thanks

haaawk commented 2 years ago

Is the repo no more active ? Thanks

It is active.

haaawk commented 2 years ago

@avelanarius let's merge this PR