Add Validators and Recommenders to ConfigDef

Bouncheck commented 2 years ago

Adds a few new Validators and Recommenders to some Configs. Some values were changed to be null by default. Some Configs have been updated to have other Configs as dependents. TTL_CONFIG is now an Integer.

avelanarius commented 2 years ago

When testing this branch under Confluent 6.0.0 I get this:

and no further properties are shown.

Bouncheck commented 2 years ago

I've mistakenly passed null instead of empty list in one place. Now seems to work as intended.

Bouncheck commented 2 years ago

Seems to be stable with following configuration:

Set up confluent locally
Set up scylla docker locally
Set up datagen connector with following config: { "name": "DatagenConnectorConnecto_0_users", "config": { "name": "DatagenConnectorConnecto_0_users", "connector.class": "io.confluent.kafka.connect.datagen.DatagenConnector", "kafka.topic": "users", "quickstart": "users" } }
Set up sink connector with the following config: { "name": "ScyllaDbSinkConnectorConnector_0_users", "config": { "value.converter.schema.registry.url": "http://localhost:8081", "key.converter.schema.registry.url": "http://localhost:8081", "name": "ScyllaDbSinkConnectorConnector_0_users", "connector.class": "io.connect.scylladb.ScyllaDbSinkConnector", "key.converter": "io.confluent.connect.avro.AvroConverter", "value.converter": "io.confluent.connect.avro.AvroConverter", "transforms": "org.apache.kafka.connect.transforms.ValueToKey", "topics": "users", "transforms.org.apache.kafka.connect.transforms.ValueToKey.type": "org.apache.kafka.connect.transforms.ValueToKey", "transforms.org.apache.kafka.connect.transforms.ValueToKey.fields": "userid", "scylladb.contact.points": "0.0.0.0", "scylladb.port": "49156", "scylladb.security.enabled": "false", "scylladb.ssl.enabled": "false", "scylladb.consistency.level": "ONE", "scylladb.keyspace": "test" } } (match port with docker)

scylladb / kafka-connect-scylladb

Add Validators and Recommenders to ConfigDef #64