search

scylladb / local-csi-driver

ScyllaDB local volume provisioner for Kubernetes based on CSI
Apache License 2.0
8 stars 6 forks source link

Add GetVolumeStats Node capability #50

Closed zimnx closed 6 months ago

zimnx commented 6 months ago

GetVolumeStats returns useful statistics about particular volume managed by the driver. These statistics are visible as kubelet metrics.

Fixes #46

rzetelskik commented 6 months ago

Shouldn't we have an e2e for this? Or is that covered by the upstream suites somehow?

zimnx commented 6 months ago

Added e2e.

zimnx commented 6 months ago

Flake - https://github.com/scylladb/k8s-local-volume-provisioner/issues/49#issuecomment-2110063328

/retest

scylla-operator-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/k8s-local-volume-provisioner/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
scylla-operator-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/scylladb/k8s-local-volume-provisioner/blob/master/OWNERS)~~ [tnozicka,zimnx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment