search

scylladb / python-driver-matrix

3 stars 11 forks source link

scylla: add 3.26.7 patch #83

Closed k0machi closed 2 months ago

k0machi commented 3 months ago

Patch also applies for .8, so closing both issues with this.

Fixes #81 Fixes #82

Jenkins

roydahan commented 3 months ago

Please add a commit message on why this patch was need.

roydahan commented 3 months ago

Maybe I don't understand the goal of the patch. Now I see that you removed the markers from the tests and moved these tests to the ignore section in the ignore.yaml, but I don't understand why.

k0machi commented 2 months ago

Maybe I don't understand the goal of the patch. Now I see that you removed the markers from the tests and moved these tests to the ignore section in the ignore.yaml, but I don't understand why.

Oh, this is just the previous patch minus the import ccmlib declaration that is now part of python-driver tests, I am not exactly sure why do we ignore tests this way, instead of using the skip markers, maybe @fruch can elaborate.

roydahan commented 2 months ago

@k0machi / @fruch ping