search

scylladb / python-driver

ScyllaDB Python Driver, originally DataStax Python Driver for Apache Cassandra
https://python-driver.docs.scylladb.com
Apache License 2.0
70 stars 42 forks source link

test_cluster.py::ClusterTests::test_idle_heartbeat - KeyError: 140483807285984 #217

Closed tchaikov closed 1 year ago

tchaikov commented 1 year ago

this test is failing recently. see https://github.com/scylladb/python-driver/actions/workflows/integration-tests.yml

quote from @fruch 's comment at https://github.com/scylladb/python-driver/pull/215#issuecomment-1479930624

this test is using id() of connection objects as keys in dictionary if there more connection create during the tests it won't find them

I have a pretty good guess that if you'll update your ccm to latest it would fail for you locally...

we recently changed the default smp in ccm from 1 to 2.

so this test which was written by datastax doesn't assume having more then 1 connection per host.

I think the easy fix would be to make sure the configuration of this specific test is 1 SMP less easy fix to change the test logic to take more shards/connections into account

fruch commented 1 year ago

@Lorak-mmk have you looked into this one ?

Lorak-mmk commented 1 year ago

I think it's fixed by this PR: https://github.com/scylladb/python-driver/pull/218 , isn't it? It seems I forgot to link the issue during PR creation, but it can be closed.