search

scylladb / python-driver

ScyllaDB Python Driver, originally DataStax Python Driver for Apache Cassandra
https://python-driver.docs.scylladb.com
Apache License 2.0
70 stars 42 forks source link

tests: fix scylla_version handling #282

Closed fruch closed 6 months ago

fruch commented 8 months ago

test shouldn't assume SCYLLA_VERSION is an actual version and should be using ccmlib to read the actual versions strings

fruch commented 8 months ago

Only failure is our unstable friend:

FAILED tests/integration/standard/test_udts.py::UDTTests::test_can_register_udt_before_connecting - cassandra.InvalidRequest: Error from server: code=2200 [Invalid query] message="Unknown field 'is_cool' in value of user defined type user"
fruch commented 6 months ago

@Lorak-mmk meanwhile I see that for tablet and running unstable/master version, the code has change, the PR was to address exactly that use case of using something with isn't a formal release

Lorak-mmk commented 6 months ago

Can you rebase? Then I'll merge

fruch commented 6 months ago

Can you rebase? Then I'll merge

rebased