search

scylladb / python-driver

ScyllaDB Python Driver, originally DataStax Python Driver for Apache Cassandra
https://python-driver.docs.scylladb.com
Apache License 2.0
70 stars 42 forks source link

ssl_options is broken on Python3.12 #284

Open fruch opened 8 months ago

fruch commented 8 months ago

This older style of no using ssl context, is broken on 3.26.4

Seems like it's was mostly addressed already in up stream:

https://github.com/datastax/python-driver/pull/1191

Maybe we should deprecated completely at our end ? Or just sync with 3.29.0 to get it ?

fruch commented 7 months ago

@avelanarius @Lorak-mmk, are we planning syncing with upstream 3.29.0, any time soon ?

or we'll need to backport the fix for this one manually ?

avelanarius commented 7 months ago

Is this issue urgent to fix?

I'd rather plan syncing with upstream to the next sprint (~start of February) since we already have a lot of stuff planned around Rust Driver.

fruch commented 7 months ago

Is this issue urgent to fix?

I'd rather plan syncing with upstream to the next sprint (~start of February) since we already have a lot of stuff planned around Rust Driver.

I can't tell exactly who is using ssl_options, but if they gonna move into python 3.12, it would stop working...

I've hit it in dtest in few tests, that wasn't using ssl_context, but I don't have anymore information beyond that

I've fixed the dtest to stop using it, so I can move to python 3.12

fruch commented 7 months ago

at least scylla tests are using only ssl_context https://github.com/search?q=repo%3Ascylladb%2Fscylladb+ssl_context&type=code