Before this change, when the driver received an invalid system.peers row it would log a very general warning:
Found an invalid row for peer (127.0.73.5). Ignoring host.
A system.peers row can be invalid for a multitude of reasons and that warning message did not describe the specific reason for the failure.
Improve the warning message by adding a specific reason why the row is considered invalid by the driver. The message now also includes the host_id or the entire row (in case the driver received a row without even the basic broadcast_rpc).
It might be a bit inelegant to introduce a side effect (logging) to the _is_valid_peer static method, however the alternative solution seemed even worse - adding that code to the already big _refresh_node_list_and_token_map.
Before this change, when the driver received an invalid
system.peersrow it would log a very general warning:A
system.peersrow can be invalid for a multitude of reasons and that warning message did not describe the specific reason for the failure.Improve the warning message by adding a specific reason why the row is considered invalid by the driver. The message now also includes the
host_idor the entire row (in case the driver received a row without even the basicbroadcast_rpc).It might be a bit inelegant to introduce a side effect (logging) to the
_is_valid_peerstatic method, however the alternative solution seemed even worse - adding that code to the already big_refresh_node_list_and_token_map.Fixes #303