search

scylladb / python-driver

ScyllaDB Python Driver, originally DataStax Python Driver for Apache Cassandra
https://python-driver.docs.scylladb.com
Apache License 2.0
70 stars 42 forks source link

~1h Stress test of topology changes (whether Python Driver survives them) #324

Closed roydahan closed 2 months ago

roydahan commented 3 months ago

https://github.com/sylwiaszunejko/scylladb/tree/stress_test

roydahan commented 2 months ago

I think it's not a driver test per-se and can be considered a valid "extended/heavy" test for test.py. The issue is that test.py doesn't have an exclude (AFAIK) test from CI (can be done with "pytest.mark").

I suggest to change the name (not a driver test), send a draft PR and I'll ask the QA team in the raft group to review and tell us if there is already something similar or it's worth adding this test as is.

kbr-scylla commented 2 months ago

@roydahan IIRC @avikivity is heavily against having tests that are excluded from CI because "nobody will run them"

and from experience I can confirm that --- I know we have (at least) one such test in test.py, and indeed, nobody has ever run it, and in fact, it's impossible to run it now because it's no longer working because some test framework functions that it was using have changed so it's no longer a sensible test.

https://github.com/scylladb/scylladb/pull/11713#issuecomment-1280057360

roydahan commented 2 months ago

Actually I didn't created this issue, just converted a draft issue to an issue.

I disagree with the observation of not having tests that are excluded from CI, you can have an extended CI and this like that.

However, I don't think this task should be done on the driver side or by the driver team, if we want to stress the topology changes, it should be done by the cluster/raft team in test.py.