Open dkropachev opened 3 months ago
I've read somewhere that 3.13 optionally / experimentally removes the GIL. Would be good to test without it, to see where we are at.
I've read somewhere that 3.13 optionally / experimentally removes the GIL. Would be good to test without it, to see where we are at.
Nit: it is a good practice to have all commits passing tests. IIUC the first commit changes used Scylla version, which breaks some tests, and subsequent commits fix this breakage. If this is true, then could you move first commit to be the last? That would keep all commits passing.
It is good idea, but, reality is that full test suit takes 30 minutes to complete, say you have 5 commits, it means that I have to spend 150
minutes on testing them.
Now, say I want to change something in the partilar commit, I have to go back to the commit I am changing, spend 30 minutes on testing it and, if code I have changed is not isolated, I have retest every commit that goes after it, does it worth it ? I think no
Sure, it is not practical to run integration tests on each commit right now, because they take too long. But:
@dkropachev
what was holding us from merging this one ?
xfail_scylla_version_lt
Fixed.
It is resurrection of https://github.com/scylladb/python-driver/pull/336 Brings python
3.13
to the integration tests. Updates scylla to5.4
and switches fromgabrielfalcao/pyenv-action@v16
toactions/setup-python@v5