scylladb / python-driver

ScyllaDB Python Driver, originally DataStax Python Driver for Apache Cassandra
https://python-driver.docs.scylladb.com
Apache License 2.0
75 stars 42 forks source link

Bring python 3.13 into integration tests #363

Open dkropachev opened 3 months ago

dkropachev commented 3 months ago

It is resurrection of https://github.com/scylladb/python-driver/pull/336 Brings python 3.13 to the integration tests. Updates scylla to 5.4 and switches from gabrielfalcao/pyenv-action@v16 to actions/setup-python@v5

mykaul commented 3 months ago

I've read somewhere that 3.13 optionally / experimentally removes the GIL. Would be good to test without it, to see where we are at.

dkropachev commented 3 months ago

I've read somewhere that 3.13 optionally / experimentally removes the GIL. Would be good to test without it, to see where we are at.

https://github.com/scylladb/python-driver/issues/370

dkropachev commented 3 months ago

Nit: it is a good practice to have all commits passing tests. IIUC the first commit changes used Scylla version, which breaks some tests, and subsequent commits fix this breakage. If this is true, then could you move first commit to be the last? That would keep all commits passing.

It is good idea, but, reality is that full test suit takes 30 minutes to complete, say you have 5 commits, it means that I have to spend 150 minutes on testing them. Now, say I want to change something in the partilar commit, I have to go back to the commit I am changing, spend 30 minutes on testing it and, if code I have changed is not isolated, I have retest every commit that goes after it, does it worth it ? I think no

Lorak-mmk commented 3 months ago

Sure, it is not practical to run integration tests on each commit right now, because they take too long. But:

fruch commented 3 weeks ago

@dkropachev

what was holding us from merging this one ?

dkropachev commented 2 weeks ago

xfail_scylla_version_lt

Fixed.