search

scylladb / python-driver

ScyllaDB Python Driver, originally DataStax Python Driver for Apache Cassandra
https://python-driver.docs.scylladb.com
Apache License 2.0
75 stars 42 forks source link

Sync with upstream 3.28.0 #364

Closed dkropachev closed 1 week ago

dkropachev commented 3 months ago

it is a peace of https://github.com/scylladb/python-driver/pull/329 that updates master to 3.28.0

dkropachev commented 3 months ago

@Lorak-mmk , @roydahan , is it good to go?

Lorak-mmk commented 3 months ago

@Lorak-mmk , @roydahan , is it good to go?

I'm reviewing right now

dkropachev commented 3 months ago

Commits that add column encryption policy make a lot of changes. I think it would be better to drop those commits altogether until we decide if and how we want to implement the encryption - adding code later is much easier than removing it.

After reviewing this I remember why I dislike current process so much...

CLE is highly integrated into cluster, session and even query, removing these commits will create unnecessary conflicts with any code done on top of it, also as bonus you are going to get a headache of merging them back and re-resolving same conflicts other way around when/if you decide to get this code in.

dkropachev commented 2 weeks ago

Commits that add column encryption policy make a lot of changes. I think it would be better to drop those commits altogether until we decide if and how we want to implement the encryption - adding code later is much easier than removing it.

After reviewing this I remember why I dislike current process so much...

Since we have already removed docs, I can't tell you that leaving code in creates way less conflicts and makes merging so much easier. Also we need to consider that we are not merging code that was not reviewed, it already went though review process on the upstream, in some cases, when we changed core on our side it does not mean much, but on the side of the code we did not touch it does.

fruch commented 1 week ago

Docs are failing to build

https://github.com/scylladb/python-driver/actions/runs/11894706235/job/33142543012#step:6:1