search

scylladb / python-driver

ScyllaDB Python Driver, originally DataStax Python Driver for Apache Cassandra
https://python-driver.docs.scylladb.com
Apache License 2.0
75 stars 42 forks source link

Cleanup tablet implementation #376

Closed sylwiaszunejko closed 1 month ago

sylwiaszunejko commented 2 months ago

Previously there was a need for different cluster configuration for tablet specific test. Now to test tablets we use scylladb version that has it as a default, so there is no need to specify so additional experimental_features

This PR addresses that problem, also it removes comments stating that tablets are experimental and fixes some inconsistencies with indentations and white spaces.

sylwiaszunejko commented 2 months ago

@dkropachev any idea why these Build wheels windows-latest checks are failing? Were there any previous problems with them recently?

dkropachev commented 2 months ago

@dkropachev any idea why these Build wheels windows-latest checks are failing? Were there any previous problems with them recently?

Win64OpenSSL-3_3_1.exe was removed from the hosting. Let's update to 3.3.2 and it will go away.

dkropachev commented 2 months ago

@dkropachev any idea why these Build wheels windows-latest checks are failing? Were there any previous problems with them recently?

Win64OpenSSL-3_3_1.exe was removed from the hosting. Let's update to 3.3.2 and it will go away.

https://github.com/scylladb/python-driver/pull/377

dkropachev commented 1 month ago

@sylwiaszunejko , can you please check why it is failing ?

sylwiaszunejko commented 1 month ago

@sylwiaszunejko , can you please check why it is failing ?

I am investigating it right now

sylwiaszunejko commented 1 month ago

After I rerun CI it passed, I am not sure what was the problem the first time