scylladb / scylla-ansible-roles

Ansible roles for deploying and managing Scylla, Scylla-Manager and Scylla-Monitoring
44 stars 38 forks source link

ansible-scylla-monitoring: Generate rule_config.yml automatically #257

Closed igorribeiroduarte closed 1 year ago

igorribeiroduarte commented 1 year ago

Looks ok to me but I wonder how this PR was tested?

I also requested @tarzanek to review this too. If this was tested:

1. Role with this PR was used to install Monitoring on a clean system.

2. Alert was simulated.

3. Email were sent.

Then I'm ok to merge it.

All that was tested.

tarzanek commented 1 year ago

looks good to me, can I merge?