scylladb / scylla-ansible-roles

Ansible roles for deploying and managing Scylla, Scylla-Manager and Scylla-Monitoring
44 stars 38 forks source link

Add support for GPG key in scylladb keyring file #283

Closed tarzanek closed 1 year ago

tarzanek commented 1 year ago

fixes #279

tarzanek commented 1 year ago

tested with 2023 and old 2022.2

tarzanek commented 1 year ago

fwiw I tested on Ubuntu 20 and no leftovers of https://github.com/scylladb/scylladb/issues/14965 anywhere with this approach

vladzcloudius commented 1 year ago

Looks good. Merging. @ebenzecri can you, please, test this with some latest SW versions that require these keys in a Training.

Please, test with U20 and U22.04. Criteria for success: 1) Installation works as expected. 2) There is not dirmngr running after the installation: sudo ps -elf | grep dirm - should be empty.

ebenzecri commented 1 year ago

Versions that I've set for testing this feature:

Ubuntu 20.04

Ubuntu 22.04

It seems it's working as expected. I'll upgrade all 2022.2 clusters to Scylla Manager 3.2 then. Thanks!