search

scylladb / scylla-bench

43 stars 36 forks source link

feature: add error-at-row-limit option #62

Closed dkropachev closed 3 years ago

dkropachev commented 3 years ago

-error-at-row-limit sets limit of errors after which thread stop executing command other threads to terminate and report error

fixes https://github.com/scylladb/scylla-bench/issues/59

dkropachev commented 3 years ago

Tested locally

roydahan commented 3 years ago

@dkropachev I'm not a golang expert, so I may be missing it, but does it retry the same key for the number of "MaxErrorsAtRow" (as I requested) or is it just counting it and eventually if we had more than MaxErrorsAtRow we raise a critical error?

dkropachev commented 3 years ago

@dkropachev I'm not a golang expert, so I may be missing it, but does it retry the same key for the number of "MaxErrorsAtRow" (as I requested) or is it just counting it and eventually if we had more than MaxErrorsAtRow we raise a critical error?

It is not, let's address it in another PR, this one is already big enough.

roydahan commented 3 years ago

I’m ok with that, but what is the current business logic of this PR? Is it counting errors every where or per key (row)?

On Wed, Jul 28, 2021 at 18:14 Dmitry Kropachev @.***> wrote:

@dkropachev https://github.com/dkropachev I'm not a golang expert, so I may be missing it, but does it retry the same key for the number of "MaxErrorsAtRow" (as I requested) or is it just counting it and eventually if we had more than MaxErrorsAtRow we raise a critical error?

It is not, let's address it in another PR, this one is already big enough.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/scylladb/scylla-bench/pull/62#issuecomment-888393601, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE75CYFTG4224T6565ESSJTT2ANGHANCNFSM5BC227XA .

dkropachev commented 3 years ago

I’m ok with that, but what is the current business logic of this PR? Is it counting errors every where or per key (row)? … On Wed, Jul 28, 2021 at 18:14 Dmitry Kropachev @.***> wrote: @dkropachev https://github.com/dkropachev I'm not a golang expert, so I may be missing it, but does it retry the same key for the number of "MaxErrorsAtRow" (as I requested) or is it just counting it and eventually if we had more than MaxErrorsAtRow we raise a critical error? It is not, let's address it in another PR, this one is already big enough. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#62 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE75CYFTG4224T6565ESSJTT2ANGHANCNFSM5BC227XA .

It is counting each error, if operation succeeded it resets the counter.