search

scylladb / scylla-bench

43 stars 36 forks source link

fix(TimeseriesGenerator): WRite and read only configured partitions f… #99

Closed aleksbykov closed 2 years ago

aleksbykov commented 2 years ago

…or timeseries

For timeseries mode sb generate more partitions that set with parameter partition_count. Method NextPartitionKey() return next partition generation if current partition key was 0.

a lot of new partitions were generated for long runs

Left only partition key as return value of the method

roydahan commented 2 years ago

@aleksbykov I'm trying to understand if it's a mistake or intended to simulate timeseries.

aleksbykov commented 2 years ago

@aleksbykov I'm trying to understand if it's a mistake or intended to simulate timeseries.

it depend on what we want. Do we want that number of partitions is static and equal to requested or it could grow

roydahan commented 2 years ago

I think that the whole intention of timeseries is to write more and more partitions, each represent a sample in time. But I'm not sure we are using it correctly on how we run it and the flags also don't make sense.

It's true that if we want to limit the amount of partitions with this flag, we will need this PR.

roydahan commented 2 years ago

Closing this one for now. We don't want or don't know if we need to change scylla-bench. It looks like the original behaviour is what was intended for timeseries.