Open kbr- opened 4 years ago
I don't completely understand what's happening though, because e.g. snapshot_test
, which fails on my laptop 100% of the time when trying to run dtests using branches scylla-ccm:master and scylla-dtest:master, sometimes passes on BYO:
https://jenkins.scylladb.com/job/scylla-master/job/byo/job/byo_build_tests_dtest/909/consoleFull
and in effect some dtests are failing.
e.g. with the following setup: scylla-ccm https://github.com/scylladb/scylla-ccm/commit/d1e62bacaef834f827b5bd5655c5900f0eef8221 (next and master at the moment of writing this issue) + scylla-dtest https://github.com/scylladb/scylla-dtest/commit/cd83fd8f8956befd1af256b91dee6456093413c0 (next and master at the moment of writing this issue)
running:
gives:
Here's how the test starts:
By reading the code and debugging, I arrived at the conclusion that the reason is https://github.com/scylladb/scylla-ccm/commit/83bdc2dcff893728587070aee69db70b88863eab, specifically these lines:
the
else
branch was causing the wait in older ccm versions (which causedstart()
to take ~25 seconds longer to finish than it currently does). I guess this is now responsible for the wait:but
wait_for_binary_interface
in ccmlib/node.py)cluster.populate(n).start()
(sowait_for_binary_proto=False
) and probably assume that the cluster is ready after this: