scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
22 stars 66 forks source link

scylla_node: start: add replace_node parameter #421

Closed bhalevy closed 1 year ago

bhalevy commented 1 year ago

To be used for replacing a node given its host_id rather than its ip address.

Makes use of the newly added --replace-node-first-boot scylla option.

Signed-off-by: Benny Halevy bhalevy@scylladb.com

bhalevy commented 1 year ago

Ref https://github.com/scylladb/scylladb/pull/12316

This change does not directly depend on the option being added since no code currently uses the new replace_node parameter, while the change is backward compatible with replace_address. but we should wait with merging it until the scylla PR is finalized and merged.

bhalevy commented 1 year ago

https://github.com/scylladb/scylladb/pull/12316 is merged

fruch commented 1 year ago

scylladb/scylladb#12316 is merged

@bhalevy this have conflict with other change you did with the boot sequence logs

bhalevy commented 1 year ago

scylladb/scylladb#12316 is merged

@bhalevy this have conflict with other change you did with the boot sequence logs

rebasing...

bhalevy commented 1 year ago

@fruch branch was rebased