search

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
20 stars 64 forks source link

make_cassandra_env: hardcode java_home to jvm8 #450

Closed fruch closed 1 year ago

fruch commented 1 year ago

since we are switching to use jvm11 for scylla, but still have test that are using cassandra 3.11 that works only with jvm8, we are hardwiring the code to always try to select the jvm8 for cassandra

mykaul commented 1 year ago

since we are switching to use jvm11 for scylla, but still have test that are using cassandra 3.11 that works only with jvm8, we are hardwiring the code to always try to select the jvm8 for cassandra

Shouldn't we switch to testing with C* 4.x? I know some of the drivers CI did.

fruch commented 1 year ago

since we are switching to use jvm11 for scylla, but still have test that are using cassandra 3.11 that works only with jvm8, we are hardwiring the code to always try to select the jvm8 for cassandra

Shouldn't we switch to testing with C* 4.x? I know some of the drivers CI did.

there are 5 tests that uses cassandra 3.11, we were waiting for a few years for 4.0 to come out of beta :) more then that there is test data from 3.X, and we probably should generate test data for 4.0

Anyhow that work shouldn't hold us from switching JVM for scylla own parts.

fruch commented 1 year ago

since we are switching to use jvm11 for scylla, but still have test that are using cassandra 3.11 that works only with jvm8, we are hardwiring the code to always try to select the jvm8 for cassandra

Shouldn't we switch to testing with C* 4.x? I know some of the drivers CI did.

raised it in dtest: https://github.com/scylladb/scylla-dtest/issues/3125