Closed tchaikov closed 1 year ago
@scylladb/ccm-maint hi maintainers, could you help review this change?
If you wanted some PR to be backported to 5.2 please tag on that PR, and maintenaners should backport
Anyhow if you do open a PR, don't into a release branch, open it on next-5.2
If you wanted some PR to be backported to 5.2 please tag on that PR, and maintenaners should backport
by "tag", do you mean comment on that PR?
Anyhow if you do open a PR, don't into a release branch, open it on next-5.2
sure. retargetting it to the next-5.2 branch.
If you wanted some PR to be backported to 5.2 please tag on that PR, and maintenaners should backport
Anyhow if you do open a PR, don't into a release branch, open it on next-5.2
Shouldn't it go into next? If it's merged into 5.2 it will be missing from 5.3+.
If you wanted some PR to be backported to 5.2 please tag on that PR, and maintenaners should backport
Anyhow if you do open a PR, don't into a release branch, open it on next-5.2
Shouldn't it go into next? If it's merged into 5.2 it will be missing from 5.3+.
It's a backport, but we probably weren't clear to @tchaikov what the process (it's documented for core, for other repos it's not that clear/documented), in some cases we might ask people to open a PR, if the backport is a bit complex (I don't think this is the case)
Ah, it does say it's a cherry-pick.
could you please let me know if i should close this PR or not? or i should "tag" #433 instead ?
so the dtest tests are able to acess the exact number of shard used for testing. for instance, some of them might need to calculate the exact total memory based on this option.
Signed-off-by: Kefu Chai kefu.chai@scylladb.com (cherry picked from commit 1362c33da05c9c566b7368c82ee87174cdc8b508)