search

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
20 stars 64 forks source link

use jmx `select-java` script to execute jmx #457

Closed fruch closed 1 year ago

fruch commented 1 year ago

since scylladb/scylla-jmx@96adf0ef51ad49b6abb98867f73cf69705f5f3e3 introduced this new script, the ccm code should be looking for it, and using it insted of using the default java or hoping for the user to set JAVA_HOME correcrtly to JMX needs

Ref: https://github.com/scylladb/scylla-jmx/commit/96adf0ef51ad49b6abb98867f73cf69705f5f3e3

fruch commented 1 year ago

Excellent, it works! (please add "Fixes #456" to the commit message).

HOWEVER, what is sad is that the test directory still has symlinks/scylla-jmx being created pointing to /usr/bin/java (I still can't figure out who does it! maybe dtest?), but at least now it's no longer being used and dtest works.

i'm keeping the symlinks/scylla-jmx since I still won't to be able to use older scylla versions that doesn't have the java-select script.

I agree it might be a bit confusing, but the situation is a bit more under control. since the two usage in CCM of java, jmx and Cassandra now can select the correct java on their own, regardless of the user selection of jvm.