Add support for Cassandra 4.1.2

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla

Apache License 2.0

20 stars 64 forks source link

Add support for Cassandra 4.1.2 #467

Open Gor027 opened 1 year ago

Gor027 commented 1 year ago

Currently, ccm fails to start a Cassandra cluster with version 4.1.2. The reason is the change in the naming of the parameters of the cassandra.yaml configuration file: https://cassandra.apache.org/doc/latest/cassandra/configuration/configuration.html As the names of the parameters are hardcoded, to support the latest version of Cassandra they need to be modified according to the table mentioned in the link above.

fruch commented 1 year ago

I did manage to get dtest running o.k. with cassandra 4.1.2. https://github.com/scylladb/scylla-dtest/pull/3130/commits/9ea68a10cc461f8361df4d77a75e34c3ea0d688f

CCM itself doesn't hardcode any of those values, it's up to who uses CCM to be aware of this difference.

I don't think CCM should be translating those automatically

Gor027 commented 1 year ago

There are 2 things that I would like to modify to avoid repeating modifications in the drivers:

When using the option --rpc-timeout in ccm updateconf it adds timeout options with names containing their units (*_in_ms)
I think it is not possible to set --batch-cl option to None as it has a default False value, so commitlog_sync_period_in_ms and commitlog_sync_batch_window_in_ms are always added to cluster.conf and cassandra.yaml files.