search

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
20 stars 64 forks source link

Fix Python 3.8 compatibility #475

Closed Lorak-mmk closed 1 year ago

Lorak-mmk commented 1 year ago

Recent change introduced typing that is incompatible with Python < 3.9. There are other Scylla projects relying on CCM (e.g. most drivers) and for some of them this change caused CI failures (as of now - for Rust driver and Python driver).

This PR fixes the problem by making this typing compatible with older Python versions. It also adds CI that runs on older Python. I wanted it to be 3.6, because that's the oldest version supported by Python driver, but it seems this version can't be installed by setup-python@v4 action, so I bumped it to 3.8

fruch commented 1 year ago

@Lorak-mmk we are not running python-driver integration tests with all versions of python (only the unittests)

I'm o.k. with doing 3.8 and up.

but we should upgrade CI where it's relevent to to 3.9 at least