Closed bhalevy closed 11 months ago
@bhalevy maybe adding those cases in test_scylla_extract_mode
?
and that test is failing:
> assert scylla_extract_mode('url=https://s3.amazonaws.com/downloads.scylladb.com/downloads/scylla-enterprise/'
'relocatable/scylladb-2022.1/scylla-enterprise-debug-aarch64-package-2022.1.rc0.0.20220331.f3ee71fba.tar.gz') == 'debug'
E AssertionError: assert 'release' == 'debug'
E - debug
E + release
nice to have a test for this, will fix
I couldn't run the test locally, but I think I found the problem and fixed it in the latest version that searches the regex pattern only on the last component of the url prefix
The current regular expression failed to match the mode for e.g
https://downloads.scylladb.com/unstable/scylla/master/relocatable/latest/scylla-debug-unified-5.4.0~dev-0.20230801.37b548f46365.x86_64.tar.gz
See https://jenkins.scylladb.com/view/master/job/scylla-master/job/dtest-debug/247/consoleText
https://jenkins.scylladb.com/view/master/job/scylla-master/job/dtest-debug/247/artifact/logs-full.debug.052/dtest-gw0.log
timeout should have been 900 seconds for debug mode if it was matched properly.