search

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
20 stars 62 forks source link

scylla_node: populate env variable when running scylla-sstable #501

Closed tchaikov closed 10 months ago

tchaikov commented 10 months ago

if scylla is built in a dtest environment, and the shared libraries which it is linked against cannot be found in the testbed's default ld.so.conf paths, the tests which run scylla-sstable would fail.

so, in this change. let's apply the self._launch_env when running scylla-sstable as well. previously, these env variables are only applied when launching scylla as a daemon.

tchaikov commented 10 months ago

tested using

$ scripts/dbuild_collect_so.sh ~/dev/scylladb/build/cmake/scylla /tmp/dynamic_libs_for_dtest
$ SCYLLA_DBUILD_SO_DIR=/tmp/dynamic_libs_for_dtest JAVA_HOME=/usr/lib/jvm/jre-11 pytest --cassandra-dir $HOME/dev/scylladb/build/cmake scylla_sstable_test.py::TestScyllaSstableDumpData::test_scylla_sstable_basic

not really a dbuild build. but i also verified by checking the env variables manually.

tchaikov commented 10 months ago

https://github.com/scylladb/scylla-ccm/actions/runs/6011490212/job/16304966887?pr=501#step:6:627

i am not sure why s-c failed to connect to scylla ..

tchaikov commented 10 months ago

@bhalevy thank you for your review. as this change fails the ccm CI test. see above. i am closing this one in favor of a minimal test: #502 . could you please review #502 instead?

will try to bring the cleanup change back later.