search

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
20 stars 62 forks source link

ccmlib/node: cleanup unsealed system sstables for offline tools #504

Closed tchaikov closed 10 months ago

tchaikov commented 10 months ago

see also 3616251066f8a520a7eec99d507dc16128e2926f

otherwise, sstablelevelreset would try to load the unsealed sstables and print out error messages in stderr if not all the components are available or is corrupted. this fails the test which checks for unexpected errors.

Fixes https://github.com/scylladb/scylladb/issues/15210

tchaikov commented 10 months ago

tested using 

$ JAVA_HOME=/usr/lib/jvm/jre-11 pytest -c $PWD/pytest.ini --cassandra-dir $HOME/dev/scylladb/build/cmake offline_tools_test.py::TestOfflineTools::test_sstablelevelreset --count 20

previously 3 out 20 runs failed. after this change all run succeeded.

tchaikov commented 10 months ago

hi @denesb and @bhalevy could you help review this change?

tchaikov commented 10 months ago

@fruch hi Israel, are you fine with this change? probably we can merge it?