search

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
20 stars 62 forks source link

scylla_node: wait_for_compactions: move override to class ScyllaNode #517

Closed bhalevy closed 8 months ago

bhalevy commented 8 months ago

Change a1624b5c471c8653e3855e0bfa3ea06422e95f2a added the method to class NodeUpgrader instead of ScyllaNode by mistake so it is a no-op and test_lcs_sstable_promotion still fails in debug mode occasionally, like https://jenkins.scylladb.com/view/master/job/scylla-master/job/dtest-debug/261/testReport/compaction_additional_test/TestLCSSSTablePromotion/Run_Dtest_Parallel_Cloud_Machines___FullDtest___full_split044___test_lcs_sstable_promotion/

ccmlib.node.TimeoutError: Waiting for compactions timed out after 300 seconds with 26 pending tasks remaining.
bhalevy commented 8 months ago

@fruch can you please backport to all branches? (And I cannot add labels, so we also need backport labels for 5.4 and soon, 2024.1)