scylla_repository: expect -SNAPSHOT in scylla-manager reloc URL

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla

Apache License 2.0

20 stars 62 forks source link

scylla_repository: expect -SNAPSHOT in scylla-manager reloc URL #530

Closed tchaikov closed 7 months ago

tchaikov commented 7 months ago

it turns out the latest scylla-manager's reloc tarball's URL contains contains "-SNAPSHOT" instead of "-dev-" in it. so let's update the test to reflect the fact.

the name should match with the name specified by scylla-manager/dist/.goreleaser.yaml 's name_template.

tchaikov commented 7 months ago

Lgtm

Maybe we should check for both ?

i'd prefer not. IMHO, the uncertainty in test is a source of the confusion. that's why i also checked scylla-manager's CI.