search

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
22 stars 65 forks source link

ccmlib/scylla_node.py: nodetool(): prepend api-port instead of append #561

Closed denesb closed 7 months ago

denesb commented 7 months ago

Nodetool commands can contain a -- sequence, after which all subsequent command line parameters are considered positional. This means that the option we are trying to add, -Dcom.scylladb.apiPort=10000, will be parsed as a positional args and will likely trigger failure in parsing the command-line arguments. Instead of appending it to the command string, prepend it. At this point, the cmd starts with the nodetool command and node.py::nodetool() will prepend host and port args. Do the same and prepend the rest api port.

Tested locally with a test which fails with the previous code.

denesb commented 7 months ago

Follow-up to https://github.com/scylladb/scylla-ccm/pull/560.

denesb commented 7 months ago

Example failure with the previous code: https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/6803/testReport/junit/alternator_tests/TesterAlternator/Tests___dtest___test_create_snapshot_and_refresh/

ccmlib.node.ToolError: Subprocess /jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/17168/share/cassandra/bin/nodetool -h 127.0.67.1 -p 7199 -Dcom.sun.jndi.rmiURLParsing=legacy refresh -- alternator_user_table user_table -Dcom.scylladb.apiPort=10000 exited with non-zero status; exit status: 2; 
stdout: error: too many positional options have been specified on the command line

Try --help.