scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
20 stars 60 forks source link

ccmlib/scylla_node: use workdir option #562

Closed margdoc closed 4 months ago

margdoc commented 4 months ago

Use the workdir option to set all subdirectories instead of setting them separately. This change allows to set options dependent on the work directory, for example, maintenance-socket.

kbr-scylla commented 4 months ago

Please prove that this doesn't break dtests by providing a Jenkins run incorporating this change that runs at least the next-gating subset of dtests

margdoc commented 4 months ago

v2:

margdoc commented 4 months ago

v3:

margdoc commented 4 months ago

Please prove that this doesn't break dtests by providing a Jenkins run incorporating this change that runs at least the next-gating subset of dtests

Ok, this PR is a draft until Jenkins run is provided.

margdoc commented 4 months ago

v4:

margdoc commented 4 months ago

Successful Jenkins run with these changes: https://jenkins.scylladb.com/job/scylla-master/job/byo/job/byo_build_tests_dtest/2103/

margdoc commented 4 months ago

@fruch ping

kbr-scylla commented 4 months ago

Merge freeze is over, @fruch can you merge?