github/workflows/integration-tests: extract RELOC_VERSION as an env variable

scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla

Apache License 2.0

20 stars 60 forks source link

github/workflows/integration-tests: extract RELOC_VERSION as an env variable #567

Closed tchaikov closed 3 months ago

tchaikov commented 3 months ago

encode RELOC_VERSION in the key of binary, so we can use different binary for testing. there is chance that newer ccm would like to use newer scylla executables for testing.

this series is more a refactory, and it does not change the version of scylla we are using, but in a follow up change, we will use a different RELOC_VERSION for testing newer scylla.

tchaikov commented 3 months ago

see also #566 for the similar changes applied to nix.yml .

fruch commented 3 months ago

@tchaikov please check why CI didn't run at all

tchaikov commented 3 months ago

changelog:

because it's not allowed to define an env var with another env var in github workflow, apply the fix like #568

tchaikov commented 3 months ago

@tchaikov please check why CI didn't run at all

@fruch sorry, it was a regression. should be fixed by #568

tchaikov commented 3 months ago

@fruch ping?

tchaikov commented 3 months ago

next step, i will extract the setting of scylla version into another yaml file as a dedicated action shared by these two existing action, so we don't need to repeat it in two workflows.