scylladb / scylla-ccm

Cassandra Cluster Manager, modified for Scylla
Apache License 2.0
22 stars 65 forks source link

github/workflows/nix: do not set env var with another env var #568

Closed tchaikov closed 6 months ago

tchaikov commented 6 months ago

this change addresses a regression introduced by 92494911.

in 92494911, we tried to set $SCYLLA_VERSION with env.RELOC_VERSION, but github action does not allow this. because the env variables in github's workflow YAML are expanded when the YAML file is parsed. so SCYLLA_VERSION is never expanded with the value of RELOC_VERSION.

so, in this change, to avoid the repeatings, we use environmental file to store SCYLLA_VERSION, so that it can be picked by the steps that consume this env var.

see also https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files