scylladb / scylla-cdc-java

Apache License 2.0
24 stars 15 forks source link

Master does not gracefully handle errors #8

Closed avelanarius closed 3 years ago

avelanarius commented 3 years ago

https://github.com/scylladb/scylla-cdc-java/blob/avelanarius-changes/scylla-cdc-base/src/main/java/com/scylladb/cdc/model/master/Master.java

In run() method, if the fetchGenerationMetadata() or getGenerationId() fails, it crashes the entire Master and it doesn't try to retry.

There should be some retry mechanism - but probably just catching ExecutionException and retrying in while(true) loop will be fine (and some delays between retries).