search

scylladb / scylla-cloud-getting-started

https://cloud-getting-started.scylladb.com
43 stars 11 forks source link

feat(ruby): adding ruby project #20

Closed cherryramatisdev closed 1 year ago

cherryramatisdev commented 1 year ago

If any improvement is necessary for this PR to be merged, please let me know!

Thanks to @DanielHe4rt for inspiring me to contribute on this repository.

DanielHe4rt commented 1 year ago

@annastuchlik @tzach I think that's everything good to go.

Maybe a last review just in case :p

also @cherryramatisdev thanks for the awesome contribution!

DanielHe4rt commented 1 year ago

Hey @cherryramatisdev I think that we're good to go on this PR. Could you please validate if there's anything missing and rebase your branch?

Thanks!

cherryramatisdev commented 1 year ago

I was reviewed a couple times and it's all good with the code propose! I did the rebase as you mentioned @DanielHe4rt

Thanks again