Closed bhalevy closed 1 month ago
@soyacz can you please look into this?
Cc @roydahan
this error is due recent upgrade of tcconfig
library in SCT runner (by dependabot when bumping requests
library).
this error is due recent upgrade of
tcconfig
library in SCT runner (by dependabot when bumpingrequests
library).
What's the planned fix?
this error is due recent upgrade of
tcconfig
library in SCT runner (by dependabot when bumpingrequests
library).What's the planned fix?
I don't know yet: or we downgrade back this one or we'll try to find root cause why it's not working. @fruch any clues before I'll dive in?
this error is due recent upgrade of
tcconfig
library in SCT runner (by dependabot when bumpingrequests
library).What's the planned fix?
I don't know yet: or we downgrade back this one or we'll try to find root cause why it's not working. @fruch any clues before I'll dive in?
I would rather not revert, it's part of a whole cycle of upgrades
It should be very easy to debug, just run the exact same commands inside hydra (or even just locally)
I thought that I tested those nemesis when introducing it, but it might not be configured correctly, and I failed to notice it.
issue created: https://github.com/thombashi/tcconfig/issues/187 I verified with 0.28.0 version (we use 0.28.1) and it worked. I propose to pin this to 0.28.0 - anyway we use it only to get the commands I suppose
apparently downgrading this one is not trivial - docker package requires it...
removing line https://github.com/thombashi/tcconfig/blob/f469c13730ff8b5e24186eba87dfe22ddd1975d6/tcconfig/shaper/htb.py#L272 fixes the issue, but still I don't know if this is the right fix and if we should go this way...
@soyacz it's a specific command that fails, i.e. other commands we use works ?
@soyacz it's a specific command that fails, i.e. other commands we use works ?
We can skip the specific command until it would be fixed
@soyacz it's a specific command that fails, i.e. other commands we use works ?
I think it doesn't matter, always fails. My proposal is to fork the repo, remove bogus line and use this repo to install tcconfig until fixed in upstream the proper way.
@soyacz it's a specific command that fails, i.e. other commands we use works ?
I think it doesn't matter, always fails. My proposal is to fork the repo, remove bogus line and use this repo to install tcconfig until fixed in upstream the proper way.
I think the bug, it's assume the command is run, and looking for the output. but we don't execute the command just print them, to use them remotely
Anyhow fork is an option
Seen in https://argus.scylladb.com/test/701dfdf1-c052-4bcf-84a5-27833356d5fe/runs?additionalRuns[]=13dae2ef-9a9d-4606-8366-2aa794bb2c1c