scylladb / scylla-code-samples

Code samples for working with ScyllaDB
Apache License 2.0
237 stars 130 forks source link

mms/java: Use Maven instead of Ant #178

Closed Lorak-mmk closed 2 years ago

Lorak-mmk commented 2 years ago

Converted mms/java to use Maven instead of Ant. Updated READMEs to reflect the changes - and fixed previosly existing errors.

Lorak-mmk commented 2 years ago

Drivers behavior is correct as Scylla used here doesn't have shard aware port enabled in config (https://github.com/scylladb/scylla-code-samples/blob/master/mms/scylla/scylla.yaml - no native_shard_aware_transport_port field). Whether that's intended is another question - I'd guess that maybe this config was created for old versions of Scylla and never updated, so shard awareness was never enabled? To fix this it should be enough to native_shard_aware_transport_port: 19042 to configs - mms/scylla/scylla.yaml and mms/scylla/scylla-replace-node.yaml

guy9 commented 2 years ago

thanks

guy9 commented 2 years ago

@tzach please merge

Lorak-mmk commented 2 years ago

@guy9 Please note that after this change the relevant pages on Scylla University must also be updated - as .jar filenames changed. Here's the list of affected pages: https://university.scylladb.com/courses/the-mutant-monitoring-system-training-course/lessons/coding-with-java-part-1/ https://university.scylladb.com/courses/the-mutant-monitoring-system-training-course/lessons/coding-with-java-part-2/ https://university.scylladb.com/courses/the-mutant-monitoring-system-training-course/lessons/coding-with-java-part-3/

guy9 commented 2 years ago

Thanks @Lorak-mmk , I already updated them :-)