refactor: ScyllaDB/Elasticsearch Query & Insertion script

scylladb / scylla-code-samples

Code samples for working with ScyllaDB

Apache License 2.0

237 stars 130 forks source link

Closed vaishnav-mk closed 1 month ago

vaishnav-mk commented 1 month ago

Removed deprecated practices:

Eliminated references to doc_type in Elasticsearch queries (no longer required).
Mentioned default port number for Elasticsearch
Addressed a deprecation warning by using client.options for ignoring index creation existence (400 status).
Enhanced Readability: Improved code formatting and removed unnecessary comments for better maintainability.

DanielHe4rt commented 1 month ago

LGTM!

DanielHe4rt commented 1 month ago

Hey @vaishnav-mk! Thanks for the contribution again.

I tested here and it work like a charm together with the ScyllaDB Python Driver. Also I did a couple of changes on the project's README that you can find already in the repository or in this commit https://github.com/scylladb/scylla-code-samples/commit/b80103cc11caf8d640edfcdc748b0b52e8ef970b.

I'll merge it right now!