search

scylladb / scylla-cqlsh

A fork of the cqlsh code
Apache License 2.0
16 stars 30 forks source link

switch from `ssl_options` to `ssl_context` #47

Closed fruch closed 1 year ago

fruch commented 1 year ago

This change give us more control when the keys are gonna be loaded, and the passphrses would be asked.

we need to make sure it happen before we start the cqlsh interpeter, and this one the passphrase is being asked from the user only once, and not multiple times on every socket being opened.

Fixes: #46

mykaul commented 1 year ago

Do we have tests for cqlsh with TLS?

fruch commented 1 year ago

Do we have tests for cqlsh with TLS?

Not in this repo

It might be easier to achieve in dtest

In SCT we are using it with TLS, in cases we run with client encryption

Testing with the passphrase might be tricky, in less we'll add a way to pass it via the command line.

fruch commented 1 year ago

Do we have tests for cqlsh with TLS?

We'll start with the tests for it in dtest, and then we'll merge this into scylla core https://github.com/scylladb/scylla-dtest/pull/3548

fruch commented 1 year ago

tests to cover this change are available now in dtest