scylladb / scylla-cqlsh

A fork of the cqlsh code
Apache License 2.0
16 stars 30 forks source link

Docker image not up-to-date since there's no 'apt-get upgrade' command #59

Closed mykaul closed 10 months ago

mykaul commented 10 months ago

See https://github.com/scylladb/scylla-cqlsh/blob/426fa0eaa72b7d46115188b1af9cdd983b923241/pylib/Dockerfile.ubuntu.py3 - similar/identical issue as https://github.com/scylladb/scylladb/issues/16222

CC @yaronkaikov

mykaul commented 10 months ago

Perhaps https://github.com/scylladb/scylla-cqlsh/blob/426fa0eaa72b7d46115188b1af9cdd983b923241/Dockerfile#L11 is also relevant here.

fruch commented 10 months ago

every time we'll build, we'll start from latest release

FROM ubuntu:bionic

Not sure why upgrade as well, we can just switch to the next ubuntu release as base ?

fruch commented 10 months ago

Perhaps

https://github.com/scylladb/scylla-cqlsh/blob/426fa0eaa72b7d46115188b1af9cdd983b923241/Dockerfile#L11

is also relevant here.

yes this is the correct one, the first one you mentioned is copied from cassandra code, and was used just for testing, not for publishing

the Dockerfile in the root folder is.

but it's still the same we are using the official python images, which get updates once there a new release. we are using the slim version to make sure we don't have any unneeded things.

but we should scan this image, and see what's there, not blindly upgrade, it can bite us as well.

mykaul commented 10 months ago

Scanning latest image, let's see. The thing is, they don't update often in and in between the underlying image - but let me complete the scanning and we'll see.

mykaul commented 10 months ago

We should release an updated package, after performing 'apt-get upgrade' most likely.