search

scylladb / scylla-cqlsh

A fork of the cqlsh code
Apache License 2.0
11 stars 29 forks source link

Draft: explicit build-time package dependencies #61

Closed mykaul closed 6 months ago

mykaul commented 7 months ago

Seen @ https://github.com/docker-library/python/blob/7899dbafd386ee264bd33574aafcd0f1369b2e21/3.11/slim-bullseye/Dockerfile#L33 Instead of installing all recommended packages, we explicitly mention what we need. It reduces the download of 10's of build-time dependencies.

What I'm not sure of - are we missing features, that are not compiled as deps are not found? (encryption comes to mind).

fruch commented 7 months ago

what are we trying to optimize here ? build time ?

mykaul commented 7 months ago

what are we trying to optimize here ? build time ?

Not optimize, reduce point of failures (I've failed twice as some repos did not respond. Less packages means less issues). I think it also helps later, with understanding when things change. (I'm still trying to figure out why Scylla container has gcc installed, for example).

fruch commented 7 months ago

what are we trying to optimize here ? build time ?

Not optimize, reduce point of failures (I've failed twice as some repos did not respond. Less packages means less issues). I think it also helps later, with understanding when things change. (I'm still trying to figure out why Scylla container has gcc installed, for example).

anyhow it's build time, if it build with those, it's o.k.

we ship a different image, where we don't install anything else