scylladb / scylla-cqlsh

A fork of the cqlsh code
Apache License 2.0
16 stars 30 forks source link

set the hostname in ssl_options.server_hostname when SSL is used #76

Closed fruch closed 6 months ago

fruch commented 6 months ago

since driver assign automatically server_hostname only with ip and don't use DNS name, cqlsh need to pass it along until that would be addressed

Fix: https://github.com/scylladb/scylla-cqlsh/issues/75

fruch commented 6 months ago

@mark-bb FYI, let me know if this works for you

mark-bb commented 6 months ago

@fruch Looks good, thanks!

mark-bb commented 6 months ago

@fruch I've created another issue on the proposed check_hostname cqlshrc property discussed here. https://github.com/scylladb/scylla-cqlsh/issues/77

mark-bb commented 6 months ago

@fruch Is it possible to provide a list of hostnames or IPs in the ssl_options parameter of a Cluster object?

fruch commented 6 months ago

@fruch Is it possible to provide a list of hostnames or IPs in the ssl_options parameter of a Cluster object?

There isn't a way to pass multiple host to cqlsh command line, regardless, for anything more complex I think we should solve on the driver level