nodetool repair options missing

[soyacz]

I would like to report an issue in page https://docs.scylladb.com//operating-scylla/nodetool-commands/repair

Problem

nodetool repair has more options than listed on docs site. All options (from nodetool help repair):

OPTIONS
        -dc <specific_dc>, --in-dc <specific_dc>
            Use -dc to repair specific datacenters

        -dcpar, --dc-parallel
            Use -dcpar to repair data centers in parallel.

        -et <end_token>, --end-token <end_token>
            Use -et to specify a token at which repair range ends

        -full, --full
            Use -full to issue a full repair.

        -h <host>, --host <host>
            Node hostname or ip address

        -hosts <specific_host>, --in-hosts <specific_host>
            Use -hosts to repair specific hosts

        -j <job_threads>, --job-threads <job_threads>
            Number of threads to run repair jobs. Usually this means number of
            CFs to repair concurrently. WARNING: increasing this puts more load
            on repairing nodes, so be careful. (default: 1, max: 4)

        -local, --in-local-dc
            Use -local to only repair against nodes in the same datacenter

        -p <port>, --port <port>
            Remote jmx agent port number

        -pl, --pull
            Use --pull to perform a one way repair where data is only streamed
            from a remote node to this node.

        -pr, --partitioner-range
            Use -pr to repair only the first range returned by the partitioner

        -pw <password>, --password <password>
            Remote jmx agent password

        -pwf <passwordFilePath>, --password-file <passwordFilePath>
            Path to the JMX password file

        -seq, --sequential
            Use -seq to carry out a sequential repair

        -st <start_token>, --start-token <start_token>
            Use -st to specify a token at which the repair range starts

        -tr, --trace
            Use -tr to trace the repair. Traces are logged to
            system_traces.events.

        -u <username>, --username <username>
            Remote jmx agent username

Suggest a fix

make explanation for other options too.

[tzach]

Good catch Did you validate all of these options works?

[soyacz]

No, I didn't validate. What we have in dtest: -et, -pr, -local, -dc, -seq, -hosts, -st, -full missing: -dcpar, -j, -p, -pl, pw, -pwf, -tr, -u

[tzach]

From the tested options only seq and full are missing Full is only relevant with Incremental repair, which is not supported in Scylla Sequential repair is indeed missing. Can you please point to the relevant tests? If it is stable and fully tested - we should add it

[soyacz]

seq: https://github.com/scylladb/scylla-dtest/blob/next/repair_additional_test.py#L1272 full: there's no specific test, but is used in various ones when using this method: https://github.com/scylladb/scylla-dtest/blob/next/repair_test.py#L150