scylladb / scylla-doc-issues

Repository for reporting issues about Scylla documentation (Deprecated)
2 stars 6 forks source link

Issue with Default in Repair Base Operation Section #871

Closed GarrettPoore closed 1 year ago

GarrettPoore commented 1 year ago

Update the path to the relevant Doc page: https://opensource.docs.scylladb.com/stable/operating-scylla/procedures/maintenance/repair.html

Problem

This feature is disabled by default.

Suggest a fix

I heard this was enabled on 5.2 but did some poking around and I think it might have been enabled since 4.6.

I don't know C++ well, but the true here flipped from false in 4.6.0. https://github.com/scylladb/scylladb/blob/scylla-4.6.0/db/config.cc#L766

Either way, in some version of Scylla this is now enabled by default.

annastuchlik commented 1 year ago

@GarrettPoore Thanks for reporting this issue. You're right; the Repair Base Operation section on the Repair page is outdated. The one that should be used as it has updated information is the separate Repair Based Node Operations page. This bug will be fixed in version 5.3; you can review it on master.

annastuchlik commented 1 year ago

The scope of this issue:

annastuchlik commented 1 year ago

Fixed by backporting: https://github.com/scylladb/scylladb/pull/12984 See online: 5.2 https://opensource.docs.scylladb.com/stable/operating-scylla/procedures/maintenance/repair.html 5.1 https://opensource.docs.scylladb.com/branch-5.1/operating-scylla/procedures/maintenance/repair.html Closing.