search

scylladb / scylla-java-driver-matrix

2 stars 7 forks source link

fix(scripts/run_test.sh): Creating missing .config directory #7

Closed Orenef11 closed 2 years ago

fruch commented 2 years ago

what about mounting this directory ? otherwise I don't think this alone would fix anything

Orenef11 commented 2 years ago

what about mounting this directory

I compared it against python-driver-matrix code, and the bash file install the same directories. Which directory do you think is missing? https://github.com/scylladb/python-driver-matrix/blob/master/scripts/run_test.sh#L38-L43

fruch commented 2 years ago

what about mounting this directory

I compared it against python-driver-matrix code, and the bash file install the same directories. Which directory do you think is missing? https://github.com/scylladb/python-driver-matrix/blob/master/scripts/run_test.sh#L38-L43

In the python matrix later the code runs in virtualenv (it's a bit different), also it's not used from the ccm commandline as here. I would compare to things in dtest run_test.sh, and there .local is being mounted

Orenef11 commented 2 years ago

@fruch I've checked it and I think the job is working now

Orenef11 commented 2 years ago

@fruch The PR is ready for review