search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
29 stars 52 forks source link

dist/debian: don't install systemd unit by install.sh, use debian/*.service #113

Closed syuu1228 closed 4 years ago

syuu1228 commented 4 years ago

Installing .service by install.sh script causes the error on installing .deb package, use debian/.service instead.

Fixes scylladb/scylla#6010 Related scylladb/scylla#5640 Related https://github.com/scylladb/scylla/commit/29285b28e2de2f07593a65a5f03977da440b2e42

avikivity commented 4 years ago

I don't see scylla-jmx.service. Did you refer to https://manpages.debian.org/testing/debhelper/dh_systemd_enable.1.en.html when you wrote debian/.service?

syuu1228 commented 4 years ago

@avikivity scylla-jmx.service is already placed at debian/scylla-jmx.service on .deb building time: https://github.com/scylladb/scylla-jmx/blob/master/dist/debian/debian_files_gen.py#L56 What currently we facing is, we package scylla-jmx.service both in debian/scylla-jmx/ and debian/*.service, it seems like the .deb package tries to install the file twice and causes the error.

It probably able to resolve by dropping debian/.service and adding systemd unit file handling script on debian/.postinst and debian/*.postrm manually (it basically just running systemctl daemon-reload), but I think current way is more simpler than that.

avikivity commented 4 years ago

Ah, thanks for the explanation.