search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
29 stars 52 forks source link

Add build/ dependency-reduced-pom.xml and scylla-apiclient/target/ to .gitignore #123

Closed bhalevy closed 4 years ago

bhalevy commented 4 years ago

Now that scylla-jmx became a submodule of scylla, I see the following artifacts under scylla tools/jmx after ninja-build

Untracked files:
  (use "git add <file>..." to include in what will be committed)
    build/
    dependency-reduced-pom.xml
    scylla-apiclient/target/

These need to be added to .gitignore otherwise git thinks that the submodule is dirty.

bhalevy commented 4 years ago

Cc @penberg

penberg commented 4 years ago

@bhalevy All of the directories are in .gitignore, no?

https://github.com/scylladb/scylla-jmx/blob/master/.gitignore

I don't quite understan why they're not getting picked up...

bhalevy commented 4 years ago

I don't see the problem anymore. Guess this issue can be closed with c0d9d0f05174638ef13c4807906941364f5627ac