Closed amoskong closed 4 years ago
The user has to install the Java environment, we're not going to bundle it.
Java11 should be used not java8 - We need to understand why Java8 is still needed and not 11
On Thu, Aug 20, 2020 at 10:22 AM Avi Kivity notifications@github.com wrote:
The user has to install the Java environment, we're not going to bundle it.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/scylladb/scylla-jmx/issues/127#issuecomment-677411406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2OCCDEGFXDQPCF4SWXUILSBTFLRANCNFSM4QFR6YKA .
Java11 should be used not java8 - We need to understand why Java8 is still needed and not 11 … On Thu, Aug 20, 2020 at 10:22 AM Avi Kivity @.***> wrote: The user has to install the Java environment, we're not going to bundle it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2OCCDEGFXDQPCF4SWXUILSBTFLRANCNFSM4QFR6YKA .
install.sh of scylla-jmx:
It only checked 1.8.0, and the error message should be fixed. 1.8, 1.11 should all work.
if ! $packaging; then
has_java=false
if [ -x /usr/bin/java ]; then
javaver=$(/usr/bin/java -version 2>&1|head -n1|cut -f 3 -d " ")
if [[ "$javaver" =~ ^\"1.8.0 ]]; then
has_java=true
fi
fi
if ! $has_java; then
echo "Please install openjdk-8 before running install.sh."
exit 1
fi
fi
openjdk11 is only available on new ubuntu distros.
For centos (7 &8), we only require java 1.8.
For ubuntu/deb: we try to find 1.8 / 1.11. If 1.8 and 1.11 all exist, 1.8 will be used. not 1.11. Is it a problem? or expected.
dist/debian/control.template:Depends: ${shlibs:Depends}, ${misc:Depends}, openjdk-8-jre-headless | openjdk-8-jre | oracle-java8-set-default | adoptopenjdk-8-hotspot-jre, %{product}-server dist/debian/control.template:Conflicts: openjdk-11-jre-headless, openjdk-11-jre, oracle-java11-set-default
@amoskong Our JMX and tools should run on both Java 8 and Java 11. Are you seeing some problem with either of them? If so, please report, and let's get it fixed.
@penberg Could it be related to https://github.com/scylladb/scylla/pull/6303 ?
@amoskong Our JMX and tools should run on both Java 8 and Java 11. Are you seeing some problem with either of them? If so, please report, and let's get it fixed.
Both versions work well. I'm asking if current order / priority is fine, Java 8 will be installed even Java 11 is also available from the apt repo. Is it expected?
The offline installer doesn't install java, does it? I'm confused.
@avikivity I think the issue is that even if you install Java before, it will not be able to install scylla-jmx and tools unless you installed java-8 !!! in debian10 for example the official Java version is 11. I think it's related to this commit https://github.com/scylladb/scylla/pull/6303/commits/e664289ce997bde27b541b8394d10c7249a1fd83
Oh, then we should drop the Conflicts tag.
according to @penberg
we run with java11 fine and the user should install java8 or java11 on his own
install.sh of scylla-jmx:
It only checked 1.8.0, and the error message should be fixed. 1.8, 1.11 should all work.
I will open a new issue for this issue.
if ! $packaging; then has_java=false if [ -x /usr/bin/java ]; then javaver=$(/usr/bin/java -version 2>&1|head -n1|cut -f 3 -d " ") if [[ "$javaver" =~ ^\"1.8.0 ]]; then has_java=true fi fi if ! $has_java; then echo "Please install openjdk-8 before running install.sh." exit 1 fi fi
version: scylla-jmx master
Currently (unified-package) offline install does't provide openjdk-8, it has to be installed in advance. It's a known issue, and it's low priority, but we don't have issue to track it.
The old offline installer (https://github.com/scylladb/scylla/wiki/Offline-Installer) depends on RPM/DEB, and openjdk dependency can be solved.
install the openjdk manually
/CC @roydahan @penberg @slivne