search

scylladb / scylla-jmx

Scylla JMX proxy
GNU Affero General Public License v3.0
29 stars 52 forks source link

fix offline installation #131

Closed amoskong closed 4 years ago

amoskong commented 4 years ago

Currently after offline installation, the scylla-jmx fails to be started. This patch fixed the problem.

Fixes: https://github.com/scylladb/scylla/issues/7098 by [PATCH] install.sh: check both openjdk-8 and openjdk-11

Fixes: https://github.com/scylladb/scylla-jmx/issues/129 by [PATCH] nonroot.conf: set WorkingDirectory to empty

amoskong commented 4 years ago

Append a patch to fix https://github.com/scylladb/scylla-jmx/issues/132

penberg commented 4 years ago

@syuu1228 Please review this.

syuu1228 commented 4 years ago

Other changes looks okay to me.

amoskong commented 4 years ago

I think we shouldn't apply $sysconfdir = /etc/default on nonroot mode. Why we want to use it on Debian variants is it's distribution's default sysconfig dir. On nonroot mode we uses $prefix/$sysconfdir, it's not /etc/default directory anyway, so no reason to apply the directory name here. I suppose just always use $prefix/etc/sysconfig is fine for nonroot mode.

If sysconfdir isn't assigned, $prefix/etc/sysconfig == $retc/../$sysconfig If sysconfdir is assigned, my change will still work.

The env file path in nonroot.conf is /home/scylla-test/scylladb/etc/sysconfig/scylla-jmx.
Actually it's installed to /home/scylla-test/scylladb/etc/default/scylla-jmx,
because the special sysconfdir is assigned in install commandline.

OK, I got it. You expect the syscondir is only assigned for root install of debian-like distros. It should not be assigned for nonroot install of debian-like distros. The limit should be added to parameters parser of install.sh

I'm fine to use default sysconfdir for nonroot install of debian-like distros. So I will remove the last patch. Then we can merge this PR.

Thanks for your review.